Unified Diff: test/runners/chromium_remote_process.js
Issue 29874649:
Issue 6822 - Report browser test errors (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Remove the finally() from the promise
Created Sept. 19, 2018, 7:10 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« test/browser/_bootstrap.js ('k')
|
test/runners/webdriver.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/runners/chromium_remote_process.js |
| =================================================================== |
| --- a/test/runners/chromium_remote_process.js |
| +++ b/test/runners/chromium_remote_process.js |
| @@ -174,16 +174,25 @@ |
| if (callResult.exceptionDetails) |
| throwException(callResult.exceptionDetails, scriptName); |
| let promiseResult = await Runtime.awaitPromise({ |
| promiseObjectId: callResult.result.objectId |
| }); |
| if (promiseResult.exceptionDetails) |
| throwException(promiseResult.exceptionDetails, scriptName); |
| + |
| + return Runtime.evaluate({ |
| + expression: "window._consoleLogs", |
| + returnByValue: true |
| + }).then(result => |
| + { |
| + if (result.result.value.failures != 0) |
| + return Promise.reject("Test Chromium (Remote Interface) failed"); |
| + }); |
| } |
| finally |
| { |
| client.close(); |
| } |
| }); |
| } |
« no previous file with comments
|
« test/browser/_bootstrap.js ('k')
|
test/runners/webdriver.js » ('j')
|
no next file with comments »
