Issue 6822 - Report browser test errors

test/runners/webdriver.js

Index: test/runners/webdriver.js
===================================================================
--- a/test/runners/webdriver.js
+++ b/test/runners/webdriver.js
@@ -19,26 +19,31 @@
 
 function executeScript(driver, name, script, scriptName, scriptArgs)
 {
   let realScript = `let f = ${script}
                     let callback = arguments[arguments.length - 1];
                     return Promise.resolve()
                       .then(() => f(...arguments))
                       .then(() => callback());`;
-  return driver.executeScript(`window.consoleLogs = [];
-                               let oldLog = console.log;
+  return driver.executeScript(`let oldLog = console.log;
                                console.log = msg => {
-                                 window.consoleLogs.push(msg);
+                                 window._consoleLogs.log.push(msg);
                                  oldLog.call(this, msg);
                                };`)
     .then(() => driver.executeAsyncScript(realScript, scriptArgs))
-    .then(() => driver.executeScript("return window.consoleLogs;"))
+    .then(() => driver.executeScript("return window._consoleLogs;"))
     .then(result =>
     {
       console.log(`\nBrowser tests in ${name}\n`);
-      result.forEach(item => console.log(item));
-    })
-    .then(() => driver.quit())
-  ;
+      for (let item of result.log)
+        console.log(item);
+      driver.quit();
+      if (result.failures != 0)
+        return Promise.reject(name);
+    }, error =>
+    {
+      driver.quit();

[Sebastian Noack, 2018/09/20 17:34:00]

When I was still using nodeunit in adblockpluschrome, I noticed that the
Chromium process weren't properly terminated if I didn't wait for the promise
returned by quit() to resolve.

[hub, 2018/09/20 19:39:54]

I didn't, but this totally make sense. Fixing this.

+      return Promise.reject(error);
+    });
 }
 
 module.exports.executeScript = executeScript;