Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/chromium_remote_process.js

Issue 29874649: Issue 6822 - Report browser test errors (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: eslint fixes Created Sept. 20, 2018, 10:26 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/runners/chromium_remote_process.js
===================================================================
--- a/test/runners/chromium_remote_process.js
+++ b/test/runners/chromium_remote_process.js
@@ -174,16 +174,25 @@
if (callResult.exceptionDetails)
throwException(callResult.exceptionDetails, scriptName);
let promiseResult = await Runtime.awaitPromise({
promiseObjectId: callResult.result.objectId
});
if (promiseResult.exceptionDetails)
throwException(promiseResult.exceptionDetails, scriptName);
+
+ return Runtime.evaluate({
+ expression: "window._consoleLogs",
+ returnByValue: true
+ }).then(result =>
+ {
+ if (result.result.value.failures != 0)
+ return Promise.reject("Chromium (Remote Interface)");
Sebastian Noack 2018/09/21 14:22:20 Nit: You can just use throw here.
hub 2018/09/21 15:39:35 Done.
+ });
}
finally
{
client.close();
}
});
}
@@ -197,12 +206,12 @@
runScript(script, scriptName, scriptArgs)
]).then(result =>
{
child.kill();
return result;
}).catch(error =>
{
child.kill();
- throw error;
+ return Promise.reject(error);
});
});
};

Powered by Google App Engine
This is Rietveld