.gitlab-ci.yml - Issue 29875559: Issue 6651,6220 - add gitlab-ci config

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .gitlab-ci.yml

Issue 29875559: Issue 6651,6220 - add gitlab-ci config (Closed) Base URL: https://github.com/adblockplus/adblockpluscore.git@3fc393a609971e48a4f2e664800da1444d75d970

Patch Set: Created Sept. 5, 2018, 12:29 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is part of Adblock Plus <https://adblockplus.org/>,

	2 # Copyright (C) 2006-present eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8 # Adblock Plus is distributed in the hope that it will be useful,

	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	11 # GNU General Public License for more details.

	12 #

	13 # You should have received a copy of the GNU General Public License

	14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	15

	16 ---

	17

	18 tests:

	19 tags:
	tlucas 2018/09/05 12:45:35 You said the tag will likely be adjusted - keep in You said the tag will likely be adjusted - keep in mind, that changing a tag here will end up in the necessity to re-provision the runners. I suggest to settle on a tag now, before the runners are provisioned (also keep in mind, the provisioning of the runners is now semi-blocked until we are sure which tags you will use (or none)) sergei 2018/09/05 12:49:47 I would ask dev-ops team to make the decision rega Show quoted text On 2018/09/05 12:45:35, tlucas wrote: > You said the tag will likely be adjusted - keep in mind, that changing a tag > here will end up in the necessity to re-provision the runners. I suggest to > settle on a tag now, before the runners are provisioned (also keep in mind, the > provisioning of the runners is now semi-blocked until we are sure which tags you > will use (or none)) I would ask dev-ops team to make the decision regarding tags, I can only contribute my opinion there. As soon as the decision is made it will be reflected firstly on gitlab in order to check that the everything works and then in this codereview to let other to review it. So firstly runners then CI config, in this case there will be no need to re-provision runners. tlucas 2018/09/06 07:14:13 I suggest to not bother dev-ops about this decisio Show quoted text On 2018/09/05 12:49:47, sergei wrote: > On 2018/09/05 12:45:35, tlucas wrote: > > You said the tag will likely be adjusted - keep in mind, that changing a tag > > here will end up in the necessity to re-provision the runners. I suggest to > > settle on a tag now, before the runners are provisioned (also keep in mind, > the > > provisioning of the runners is now semi-blocked until we are sure which tags > you > > will use (or none)) > > I would ask dev-ops team to make the decision regarding tags, I can only > contribute my opinion there. As soon as the decision is made it will be > reflected firstly on gitlab in order to check that the everything works and then > in this codereview to let other to review it. So firstly runners then CI config, > in this case there will be no need to re-provision runners. I suggest to not bother dev-ops about this decision, FWIW i expect them to be indifferent about the tags ;) And since i'll likely be asked what you ask them about this, i might as well just answer directly: let's stick to nodejs for this, since it's nodejs running here. Sebastian Noack 2018/09/06 19:36:27 As far as I understand, tags serve to match jobs w As far as I understand, tags serve to match jobs with runners. So if we'd have a cluster of runners, this would tell the CI to only run this job on a runner that is tagged "nodejs". However, we only have one runner at the moment, and once we add more runners, we don't know yet, how we will tag those. So (unless I misunderstood something), I wouldn't configure any tags for now (which would also be consistent with the configuration we have for adblockpluschrome).
	20 - nodejs

	21 before_script:

	22 - mkdir -p .git/info

	23 - ./ensure_dependencies.py

	24 - npm install

	25 script:

	26 - npm test

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »