Issue 6913 Some test cases fail on Microsoft Edge

qunit/tests/url.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 {
-  const {extractHostFromFrame,

[geo, 2018/09/06 10:24:10]

I know that this change is not related to this particular issue, but it's pretty
small, and I would have had to either use `let` for the platform import to be
consistent with this module, or `const` to be consistent with the rest of the
code. So I choose to be consistent with the rest of the code and updated this
import as well. 

[Sebastian Noack, 2018/09/06 13:43:21]

I agree, but while on it, it also seems unnecessary to wrap this line.

[geo, 2018/09/06 20:10:47]

You're right. I was so focused on that let and const, that I didn't even
noticed. Thank you!

-       isThirdParty} = require("../../lib/url");
+  const {extractHostFromFrame, isThirdParty} = require("../../lib/url");
   const {platform} = require("info");
 
   QUnit.module("URL/host tools");
 
   test("Extracting hostname from frame", () =>
   {
     function testFrameHostname(hierarchy, expectedHostname, message)
     {
       let frame = null;
 
       for (let url of hierarchy)
         frame = {parent: frame, url: new URL(url)};
 
       equal(extractHostFromFrame(frame), expectedHostname, message);
     }
 
     testFrameHostname(["http://example.com/"], "example.com", "single frame");
     testFrameHostname(["http://example.com/", "http://example.org/"],
                       "example.org", "with parent frame");
     testFrameHostname(["http://example.com/", "data:text/plain,foo"],
                       "example.com", "data: URL, hostname in parent");
     testFrameHostname(["http://example.com/", "about:blank", "about:blank"],
                       "example.com", "about:blank, hostname in ancestor");
     testFrameHostname(["about:blank", "about:blank"], "",
                       "about:blank, no hostname");
+
     // Currently there are two bugs in Microsoft Edge (EdgeHTML 17.17134)

[Sebastian Noack, 2018/09/06 13:43:21]

Nit: It might read better with a blank line above.

[geo, 2018/09/06 20:10:47]

Done.

     // that would make this two assertions fail,
     // so for now we are not running them on this platform.
-    // See: https://issues.adblockplus.org/ticket/6913

[Sebastian Noack, 2018/09/06 13:43:21]

Can we link to the Microsoft Edge bugs directly, rather than the issue in our
issue tracker?

[geo, 2018/09/06 20:10:47]

Done.

+    // See:
+    // with punycode: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18861990/
+    // with auth credentials: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8004284/
     if (platform != "edgehtml")
     {
       testFrameHostname(["http://xn--f-1gaa.com/"], "xn--f-1gaa.com",
                         "with punycode");
       testFrameHostname(["http://user:password@example.com/"], "example.com",
                         "with auth credentials");
     }
   });
 
   test("Third-party checks", () =>
@@ skipping 69 matching lines @@
     testThirdParty(
       "[::ffff:192.0.2.128]", "[::ffff:192.1.2.128]", true,
       "different IPv4-mapped IPv6 address is third-party"
     );
     testThirdParty("xn--f-1gaa.com", "f\u00f6\u00f6.com", false,
                    "same IDN isn't third-party");
     testThirdParty("example.com..", "example.com....", false,
                    "traling dots are ignored");
   });
 }