Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: qunit/tests/url.js

Issue 29876558: Issue 6913 Some test cases fail on Microsoft Edge (Closed)
Patch Set: Created Sept. 6, 2018, 8:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: qunit/tests/url.js
diff --git a/qunit/tests/url.js b/qunit/tests/url.js
index 735ffbb2b06ddd59131c8b2727145da8ee7362d7..552d6217bcba2210046dceabc19e903848b92859 100644
--- a/qunit/tests/url.js
+++ b/qunit/tests/url.js
@@ -18,34 +18,11 @@
"use strict";
{
- let {extractHostFromFrame,
- isThirdParty} = require("../../lib/url");
+ const {extractHostFromFrame, isThirdParty} = require("../../lib/url");
+ const {platform} = require("info");
QUnit.module("URL/host tools");
- test("Extracting hostname from URL", () =>
- {
- function testURLHostname(url, expectedHostname, message)
- {
- equal(new URL(url).hostname, expectedHostname, message);
- }
-
- testURLHostname("http://example.com/foo", "example.com", "with path");
- testURLHostname("http://example.com/?foo=bar", "example.com", "with query");
- testURLHostname("http://example.com/#top", "example.com", "with hash");
- testURLHostname("http://example.com:8080/", "example.com", "with port");
- testURLHostname("http://user:password@example.com/", "example.com",
- "with auth credentials");
- testURLHostname("http://xn--f-1gaa.com/", "xn--f-1gaa.com",
- "with punycode");
- testURLHostname("about:blank", "", "about:blank");
- testURLHostname("data:text/plain,foo", "", "data: URL");
- testURLHostname("ftp://example.com/", "example.com", "ftp: URL");
- testURLHostname("http://1.2.3.4:8000/", "1.2.3.4", "IPv4 address");
- testURLHostname("http://[2001:db8:85a3::8a2e:370:7334]/",
- "[2001:db8:85a3::8a2e:370:7334]", "IPv6 address");
- });
-
test("Extracting hostname from frame", () =>
{
function testFrameHostname(hierarchy, expectedHostname, message)
@@ -67,8 +44,20 @@
"example.com", "about:blank, hostname in ancestor");
testFrameHostname(["about:blank", "about:blank"], "",
"about:blank, no hostname");
- testFrameHostname(["http://xn--f-1gaa.com/"], "xn--f-1gaa.com",
- "with punycode");
+
+ // Currently there are two bugs in Microsoft Edge (EdgeHTML 17.17134)
+ // that would make this two assertions fail,
+ // so for now we are not running them on this platform.
+ // See:
+ // with punycode: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18861990/
+ // with auth credentials: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8004284/
+ if (platform != "edgehtml")
+ {
+ testFrameHostname(["http://xn--f-1gaa.com/"], "xn--f-1gaa.com",
+ "with punycode");
+ testFrameHostname(["http://user:password@example.com/"], "example.com",
+ "with auth credentials");
+ }
});
test("Third-party checks", () =>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld