Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 29879647: Issue 6944 - Added EasyList Portuguese (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by hub
Modified:
1 year, 5 months ago
Reviewers:
kzar, Manish Jethani
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6944 - Added EasyList Portuguese

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/content/ui/subscriptions.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hub
1 year, 5 months ago (2018-09-13 12:52:44 UTC) #1
Manish Jethani
Should we change "Portuguese easylist" in the commit message to "EasyList Portuguese", as the list ...
1 year, 5 months ago (2018-09-13 14:31:01 UTC) #2
hub
On 2018/09/13 14:31:01, Manish Jethani wrote: > Should we change "Portuguese easylist" in the commit ...
1 year, 5 months ago (2018-09-13 15:06:39 UTC) #3
Manish Jethani
On 2018/09/13 15:06:39, hub wrote: > On 2018/09/13 14:31:01, Manish Jethani wrote: > > Should ...
1 year, 5 months ago (2018-09-13 15:20:21 UTC) #4
hub
1 year, 5 months ago (2018-09-13 15:44:53 UTC) #5
On 2018/09/13 15:20:21, Manish Jethani wrote:
> On 2018/09/13 15:06:39, hub wrote:
> > On 2018/09/13 14:31:01, Manish Jethani wrote:
> > > Should we change "Portuguese easylist" in the commit message to "EasyList
> > > Portuguese", as the list seems to call itself?
> > > 
> > > LGTM (also: I haven't created the next bookmark in core, please wait
before
> > > committing, keep this review open)
> > 
> > we want it for this upcoming release.
> 
> Oh well, so are you going to file a dependency update issue? In that case,
feel
> free to land this in master and update the adblockpluschrome dependency to
this
> commit. (But make sure Sebastian agrees with the dependency update.)

Filed
https://issues.adblockplus.org/ticket/6949
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5