Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(653)

Issue 29879650: Issue 6950 - Don't include headers and metadata from includes into output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 4 hours ago by Sebastian Noack
Modified:
2 days, 9 hours ago
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue 6950 - Don't include headers and metadata from includes into output

Patch Set 1 : #

Patch Set 2 : Simplify regexp #

Total comments: 5

Patch Set 3 : Test for "Last modified" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M abp/filters/parser.py View 1 3 chunks +4 lines, -7 lines 0 comments Download
M abp/filters/renderer.py View 4 chunks +15 lines, -19 lines 0 comments Download
M tests/test_differ.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/test_parser.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Sebastian Noack
6 days, 3 hours ago (2018-09-13 15:58:49 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29879650/diff/29880563/abp/filters/parser.py File abp/filters/parser.py (right): https://codereview.adblockplus.org/29879650/diff/29880563/abp/filters/parser.py#newcode143 abp/filters/parser.py:143: METADATA_REGEXP = re.compile(r'(.*?)\s*:\s*(.*)') This is what we will be ...
5 days, 4 hours ago (2018-09-14 14:36:55 UTC) #2
Vasily Kuznetsov
Hi Sebastian, LGTM, but what do you think about keeping "Last modified" in the list ...
5 days, 4 hours ago (2018-09-14 15:09:35 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29879650/diff/29880563/tests/test_parser.py File tests/test_parser.py (left): https://codereview.adblockplus.org/29879650/diff/29880563/tests/test_parser.py#oldcode168 tests/test_parser.py:168: '! Last modified: 26 Jul 2018 02:10 UTC', On ...
5 days, 3 hours ago (2018-09-14 15:33:25 UTC) #4
Vasily Kuznetsov
2 days, 9 hours ago (2018-09-17 09:41:36 UTC) #5
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5