Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(603)

Issue 29879940: Issue 6923 - Simplify parsing of metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 2 hours ago by Sebastian Noack
Modified:
3 days, 6 hours ago
Reviewers:
Manish Jethani
Visibility:
Public.

Description

Issue 6923 - Simplify parsing of metadata

Patch Set 1 #

Patch Set 2 : Further simplify regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M lib/synchronizer.js View 1 1 chunk +5 lines, -8 lines 0 comments Download
M test/synchronizer.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Sorry, we changed the semantics in python-abp again [1], now stopping to parse any further ...
6 days, 2 hours ago (2018-09-13 16:10:27 UTC) #1
Manish Jethani
On 2018/09/13 16:10:27, Sebastian Noack wrote: > Sorry, we changed the semantics in python-abp again ...
5 days, 13 hours ago (2018-09-14 05:25:44 UTC) #2
Sebastian Noack
On 2018/09/14 05:25:44, Manish Jethani wrote: > Is there a specific reason why we don't ...
5 days, 4 hours ago (2018-09-14 14:30:27 UTC) #3
Manish Jethani
On 2018/09/14 14:30:27, Sebastian Noack wrote: > On 2018/09/14 05:25:44, Manish Jethani wrote: > > ...
3 days, 7 hours ago (2018-09-16 11:15:09 UTC) #4
Manish Jethani
3 days, 7 hours ago (2018-09-16 11:28:11 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5