Unified Diff: lib/options.js
Issue 29883571:
Issue 6777 - Clicking Subscribe link on testpages.adblockplus.org works only the second time (Closed)
Patch Set:
Created Sept. 17, 2018, 5:01 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/options.js |
| diff --git a/lib/options.js b/lib/options.js |
| index fb15fe6db3d39d73573231f9bea9636608f97942..5ac6c66f61253dbe28955b1874f542b148282fcf 100644 |
| --- a/lib/options.js |
| +++ b/lib/options.js |
| @@ -44,11 +44,12 @@ function findOptionsTab(callback) |
| return; |
| } |
| - // Newly created tabs might have about:blank as their URL in Firefox rather |
| - // than the final options page URL, we need to wait for those to finish |
| - // loading. |
| + // Newly created tabs might have about:blank as their URL in Firefox |
| + // or undefined in Microsoft Edge rather than the final options page URL, |
| + // we need to wait for those to finish loading. |
| let potentialOptionTabIds = new Set( |
| - tabs.filter(tab => tab.url == "about:blank" && tab.status == "loading") |
| + tabs.filter(tab => |
| + (tab.url == "about:blank" || !tab.url) && tab.status == "loading") |
| .map(tab => tab.id) |
| ); |
| if (potentialOptionTabIds.size == 0) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
