Issue 6504 - Remove element hiding emulation code related to style sheets

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 589 matching lines @@
 
 function shouldObserveCharacterData(patterns)
 {
   return patterns.some(pattern => pattern.dependsOnCharacterData);
 }
 
 class ElemHideEmulation
 {
   constructor(addSelectorsFunc, hideElemsFunc)
   {
+    // Note: The first parameter to this constructor was previously used for
+    // injecting style sheets into the document for :-abp-properties() but this
+    // code has since moved on to use inline styles for all types of emulation
+    // filters (#6610). Nevertheless, there is a plan to go back to using style
+    // sheets on platforms that support the tabs.removeCSS API (#6504); hence
+    // this first parameter remains for now.
+
     this._filteringInProgress = false;
     this._lastInvocation = -MIN_INVOCATION_INTERVAL;
     this._scheduledProcessing = null;
 
     this.document = document;
-    this.addSelectorsFunc = addSelectorsFunc;
     this.hideElemsFunc = hideElemsFunc;
     this.observer = new MutationObserver(this.observe.bind(this));
   }
 
   isSameOrigin(stylesheet)
   {
     try
     {
       return new URL(stylesheet.href).origin == this.document.location.origin;
     }
@@ skipping 82 matching lines @@
    * @param {function} [done]
    *    Callback to call when done.
    */
   _addSelectors(stylesheets, mutations, done)
   {
     if (testInfo)
       testInfo.lastProcessedElements.clear();
 
     let patterns = filterPatterns(this.patterns, {stylesheets, mutations});
 
-    let selectors = [];
-    let selectorFilters = [];
-
     let elements = [];
     let elementFilters = [];
 
     let cssStyles = [];
 
     // If neither any style sheets nor any DOM mutations have been specified,
     // do full processing.
     if (!stylesheets && !mutations)
       stylesheets = this.document.styleSheets;
 
@@ skipping 45 matching lines @@
     let generator = null;
 
     let processPatterns = () =>
     {
       let cycleStart = performance.now();
 
       if (!pattern)
       {
         if (!patterns.length)
         {
-          if (selectors.length > 0)
-            this.addSelectorsFunc(selectors, selectorFilters);
           if (elements.length > 0)
             this.hideElemsFunc(elements, elementFilters);
           if (typeof done == "function")
             done();
           return;
         }
 
         pattern = patterns.shift();
 
         let evaluationTargets = targets;
@@ skipping 173 matching lines @@
           characterData: shouldObserveCharacterData(this.patterns),
           subtree: true
         }
       );
       this.document.addEventListener("load", this.onLoad.bind(this), true);
     }
   }
 }
 
 exports.ElemHideEmulation = ElemHideEmulation;