Noissue - Fixed: Error was silently ignored in Promise.finally() polyfill in tests

test/wrappers/pages.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const TEST_PAGES_URL = "https://testpages.adblockplus.org/";
 
 const assert = require("assert");
 const Jimp = require("jimp");
 const {By} = require("selenium-webdriver");
 
 // Once we require Node.js >= 10 this should be replaced with
 // the built-in finally() method of the Promise object.
 function promiseFinally(p, callback)
 {
-  return p.then(callback, callback);
+  return p.then(
+    callback,
+    err => Promise.resolve(callback()).then(() =>
+      Promise.reject(err)
+    )
+  );
 }
 
 function closeWindow(driver, goTo, returnTo, callback)
 {
   return promiseFinally(
     driver.switchTo().window(goTo).then(() =>
       promiseFinally(
         new Promise(resolve => resolve(callback && callback())),
         () => driver.close()
       )
@@ skipping 199 matching lines @@
                 title
               )
             );
           });
         }
         return p2;
       });
     return p1;
   });
 });