Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterListener.js

Issue 29886685: Issue 6856 - Remove FilterStorage.moveSubscription (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore
Patch Set: Address PS4 Comment Created Oct. 1, 2018, 2:31 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/filterStorage.js » ('j') | lib/filterStorage.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterListener.js
===================================================================
--- a/lib/filterListener.js
+++ b/lib/filterListener.js
@@ -103,17 +103,16 @@
filterNotifier.on("filter.removed", onFilterRemoved);
filterNotifier.on("filter.disabled", onFilterDisabled);
filterNotifier.on("filter.moved", onGenericChange);
filterNotifier.on("subscription.added", onSubscriptionAdded);
filterNotifier.on("subscription.removed", onSubscriptionRemoved);
filterNotifier.on("subscription.disabled", onSubscriptionDisabled);
filterNotifier.on("subscription.updated", onSubscriptionUpdated);
- filterNotifier.on("subscription.moved", onGenericChange);
filterNotifier.on("subscription.title", onGenericChange);
filterNotifier.on("subscription.fixedTitle", onGenericChange);
filterNotifier.on("subscription.homepage", onGenericChange);
filterNotifier.on("subscription.downloadStatus", onGenericChange);
filterNotifier.on("subscription.lastCheck", onGenericChange);
filterNotifier.on("subscription.errors", onGenericChange);
filterNotifier.on("load", onLoad);
@@ -332,17 +331,17 @@
{
isDirty = 0;
defaultMatcher.clear();
ElemHide.clear();
ElemHideEmulation.clear();
ElemHideExceptions.clear();
Snippets.clear();
- for (let subscription of FilterStorage.subscriptions)
+ for (let subscription of FilterStorage.subscriptions())
{
if (!subscription.disabled)
addFilters(subscription.filters);
}
}
function onSave()
{
« no previous file with comments | « no previous file | lib/filterStorage.js » ('j') | lib/filterStorage.js » ('J')

Powered by Google App Engine
This is Rietveld