Issue 6969 - Implement abort-on-property-read snippet

lib/content/snippets.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 503 matching lines @@
   if (currentDescriptor && !currentDescriptor.configurable)
     return false;
 
   Object.defineProperty(object, property, descriptor);
   return true;
 }
 
 /**
  * Patches a property on the window object to abort execution when the
  * property is read.
- * No error will be printed in the console.

[Manish Jethani, 2018/10/31 19:54:49]

Nit: Again, is the "No error will be printed" part really relevant to a filter
list author or anyone working on this code? If you think so, that's fine, but in
that case we could keep the tense consistent (i.e. "No error is printed to the
console").

[Manish Jethani, 2018/10/31 19:54:49]

Nit: Even though it doesn't matter to the generated documentation (since
whitespace is not relevant for HTML), I leave a blank line between paragraphs
here. We could do the same in this case (i.e. a blank line before and after "No
error ...")

[hub, 2018/10/31 20:44:16]

Done.

[hub, 2018/10/31 20:44:17]

Done.

+ *
+ * No error is be printed to the console.
+ *
  * The idea originates from

[Manish Jethani, 2018/10/31 19:54:49]

Nit: Period at the end of the sentence.

[hub, 2018/10/31 20:44:16]

Done.

- * {@link https://github.com/uBlockOrigin/uAssets/blob/80b195436f8f8d78ba713237bfc268ecfc9d9d2b/filters/resources.txt#L1703 uBlock Origin}
+ * {@link https://github.com/uBlockOrigin/uAssets/blob/80b195436f8f8d78ba713237bfc268ecfc9d9d2b/filters/resources.txt#L1703 uBlock Origin}.
  *
  * @param {string} property The name of the property.
  */
 function abortOnPropertyRead(property)
 {
   if (!property)
     return;
 
   let rid = randomId();
 
   function abort()
   {
     throw new ReferenceError(rid);
   }
 
+  let {onerror} = window;
   if (wrapPropertyAccess(window, property, {get: abort, set() {}}))
   {
-    let {onerror} = window;

[Manish Jethani, 2018/10/31 19:38:16]

Can we move this line outside the if block? In theory somebody could want to
wrap "window.onerror" and then this would bomb.

[hub, 2018/10/31 20:44:16]

It can be moved.

But it would still bomb if it was wrapped, on the line below.

[Manish Jethani, 2018/10/31 20:52:22]

Alright, fair enough.

     window.onerror = (message, ...rest) =>
     {
       if (typeof message == "string" && message.includes(rid))
         return true;
       if (typeof onerror == "function")
         return (() => {}).call.call(onerror, this, message, ...rest);
     };
   }
 }
 
 exports["abort-on-property-read"] = makeInjector(abortOnPropertyRead,
                                                  wrapPropertyAccess,
                                                  randomId);