Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/content/snippets.js

Issue 29886700: Issue 6969 - Implement abort-on-property-read snippet (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Addressed all review but the snippets parameters. Created Sept. 25, 2018, 4:28 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/content/snippets.js
===================================================================
--- a/lib/content/snippets.js
+++ b/lib/content/snippets.js
@@ -431,8 +431,59 @@
object + "";
if (typeof dir == "function")
dir.call(this, object);
};
}
exports["dir-string"] = makeInjector(dirString);
+
+function randomId()
+{
+ // 2176782336 is 36^6 which mean 6 chars [a-z0-9]
+ // 60466176 is 36^5
+ // 2176782336 - 60466176 = 2116316160. This ensure always 6 chars
+ // for when Math.random() returns 0.0
+ return (Math.floor(Math.random() * 2116316160 + 60466176)).toString(36);
Manish Jethani 2018/09/25 12:25:22 Nit: The parentheses around `Math.foor(...)` are u
hub 2018/09/25 15:40:43 Done.
+}
+
+/**
+ * Will patch a property on the window object to abort when read.
+ * It will intercept the onerror callback and block it if tagged.
+ *
+ * @todo handle properties of properties.
+ *
+ * @param {string} prop the name of the property.
+ */
+function abortOnPropertyRead(...props)
+{
+ if (props.length == 0)
+ return;
+
+ let magic = randomId();
+
+ let abort = function()
+ {
+ throw new ReferenceError(magic);
+ };
+
+ let {onerror} = window;
+ window.onerror = (message, ...rest) =>
+ {
+ if (typeof message == "string" && message.includes(magic))
+ return true;
+ if (onerror && typeof onerro == "function")
+ return onerror(this, message, ...rest);
+ };
+
+ let patch = function(o, p)
+ {
+ // simple property
+ let d = Object.getOwnPropertyDescriptor(o, p);
+ if (!d || d.get != abort)
+ Object.defineProperty(o, p, {get: abort, set() {}});
+ };
+ for (let prop of props)
+ patch(window, prop);
+}
+
+exports["abort-on-property-read"] = makeInjector(abortOnPropertyRead, randomId);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld