Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 29887585: Issue #5352 - generate_static_pages cannot deal with directories being turned into regular pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks ago by Tudor Avram
Modified:
2 days, 8 hours ago
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue #5352 - generate_static_pages cannot deal with directories being turned into regular pages

Patch Set 1 #

Total comments: 20

Patch Set 2 : Addressed comments from Patch #1 #

Total comments: 10

Patch Set 3 : Addressed comments from Patch Set #2 #

Patch Set 4 : Fixed issue causing tests to fail in Patch Set #3 #

Patch Set 5 : Addressed comments from Patch Set #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -10 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M .hgignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M cms/bin/generate_static_pages.py View 1 2 3 3 chunks +89 lines, -10 lines 0 comments Download
M tests/expected_output/en/sitemap View 1 chunk +1 line, -0 lines 0 comments Download
A tests/test_generation_exceptional_cases.py View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
A tests/test_site/pages/foo/bar.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tox.ini View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12
Tudor Avram
Hi Vasily, Here is my fix for the issue for raising an exception when turning ...
4 weeks ago (2018-09-21 13:37:34 UTC) #1
Vasily Kuznetsov
Hi Tudor! The overall approach looks good. I have some comments on code details though ...
3 weeks, 4 days ago (2018-09-24 11:58:47 UTC) #2
Tudor Avram
Hi Vasily, Thanks for your feedback! I just had a small comment on the `makedirs()` ...
3 weeks, 4 days ago (2018-09-24 13:26:45 UTC) #3
Tudor Avram
Also, one more question (see below): https://codereview.adblockplus.org/29887585/diff/29887586/.gitignore File .gitignore (right): https://codereview.adblockplus.org/29887585/diff/29887586/.gitignore#newcode9 .gitignore:9: .idea/ On 2018/09/24 ...
3 weeks, 4 days ago (2018-09-24 14:04:52 UTC) #4
Vasily Kuznetsov
Hi Tudor, > Also, from looking at the os.makedirs() code, it looks like it would ...
3 weeks, 4 days ago (2018-09-24 14:42:23 UTC) #5
Tudor Avram
Hi Vasily, I addressed your comments from the previous patch. I also refactored a couple ...
3 weeks, 4 days ago (2018-09-24 16:10:00 UTC) #6
Vasily Kuznetsov
Hi Tudor! Almost there. Just a few minor comments. Cheers, Vasily https://codereview.adblockplus.org/29887585/diff/29890605/cms/bin/generate_static_pages.py File cms/bin/generate_static_pages.py (right): ...
3 weeks, 1 day ago (2018-09-27 11:05:08 UTC) #7
Tudor Avram
Hi Vasily, I addressed all of your comments (except removing `script_runner` for one of the ...
2 weeks, 1 day ago (2018-10-04 06:34:19 UTC) #8
Tudor Avram
Hi Vasily, Really sorry, just dicovered that my previous change broke a couple of tests. ...
2 weeks, 1 day ago (2018-10-04 09:56:41 UTC) #9
Vasily Kuznetsov
Hi Tudor! Let's also convert test_generate_fifo_instead_of_file and then it's done (see details below). Cheers, Vasily ...
2 weeks ago (2018-10-05 09:40:44 UTC) #10
Tudor Avram
Hi Vasily, Here is the change for the last test. Sorry again for all this ...
2 weeks ago (2018-10-05 11:28:34 UTC) #11
Vasily Kuznetsov
2 weeks ago (2018-10-05 11:42:40 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5