Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 29889555: Issue 6975 - Check for specific anti-circumvention subscription URL (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Manish Jethani
Modified:
1 year, 1 month ago
Reviewers:
hub, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Related to https://issues.adblockplus.org/ticket/6974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M lib/filterListener.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/filterListener.js View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
1 year, 1 month ago (2018-09-23 11:36:21 UTC) #1
Manish Jethani
Patch Set 1 This is related to https://issues.adblockplus.org/ticket/6974 This fix would work for users who ...
1 year, 1 month ago (2018-09-23 11:39:28 UTC) #2
Sebastian Noack
As discussed on the issue rather than requiring external code to set the type property ...
1 year, 1 month ago (2018-09-24 01:58:05 UTC) #3
Manish Jethani
On 2018/09/24 01:58:05, Sebastian Noack wrote: > As discussed on the issue rather than requiring ...
1 year, 1 month ago (2018-09-24 07:27:48 UTC) #4
Sebastian Noack
On 2018/09/24 07:27:48, Manish Jethani wrote: > On 2018/09/24 01:58:05, Sebastian Noack wrote: > > ...
1 year, 1 month ago (2018-09-24 13:03:10 UTC) #5
Manish Jethani
On 2018/09/24 13:03:10, Sebastian Noack wrote: > On 2018/09/24 07:27:48, Manish Jethani wrote: > > ...
1 year, 1 month ago (2018-09-24 13:23:07 UTC) #6
Manish Jethani
On 2018/09/24 13:23:07, Manish Jethani wrote: > On 2018/09/24 13:03:10, Sebastian Noack wrote: > > ...
1 year, 1 month ago (2018-09-24 13:59:47 UTC) #7
hub
1 year, 1 month ago (2018-09-24 14:48:46 UTC) #8
I'm not very keen on hardcoding a URL, but if we want this working in 3.4, let's
have it.

LGTM.

But this issue should be fixed properly in next.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5