Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 29890593: Noissue - Enable test runner to run on Windows and add documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by Sebastian Noack
Modified:
11 months ago
Reviewers:
tlucas
CC:
geo, rossg
Visibility:
Public.

Description

Noissue - Enable test runner to run on Windows and add documentation

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed typo #

Patch Set 3 : Use double quotes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M README.md View 1 3 chunks +22 lines, -4 lines 0 comments Download
M package.json View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/all.js View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
We cannot run "npm test" from within the Linux environment on Windows, since Selenium would ...
11 months ago (2018-09-24 14:49:51 UTC) #1
tlucas
Can you please file an additional merge request on gitlab.com for this? Not as a ...
11 months ago (2018-09-25 12:25:15 UTC) #2
Sebastian Noack
There you go: https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31168869 Note that this branch also includes the other two changes to ...
11 months ago (2018-09-25 16:21:25 UTC) #3
tlucas
11 months ago (2018-09-25 17:03:44 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5