Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29890593: Noissue - Enable test runner to run on Windows and add documentation (Closed)
Left Patch Set: Created Sept. 24, 2018, 2:45 p.m.
Right Patch Set: Use double quotes Created Sept. 24, 2018, 4:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | package.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox
2 ========================================================== 2 ==========================================================
3 3
4 This repository contains the platform-specific Adblock Plus source code for 4 This repository contains the platform-specific Adblock Plus source code for
5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build
6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted
7 from other repositories automatically (see _dependencies_ file). 7 from other repositories automatically (see _dependencies_ file).
8 8
9 Note that the Firefox extension built from this repository is the new 9 Note that the Firefox extension built from this repository is the new
10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 extension's Options page, open the JavaScript Console and type in: 91 extension's Options page, open the JavaScript Console and type in:
92 92
93 location.href = "qunit/index.html"; 93 location.href = "qunit/index.html";
94 94
95 The unit tests will run automatically once the page loads. 95 The unit tests will run automatically once the page loads.
96 96
97 ### External test runner 97 ### External test runner
98 98
99 There is also an external test runner that can be invoked from the 99 There is also an external test runner that can be invoked from the
100 command line in order to run the unit tests along some integration 100 command line in order to run the unit tests along some integration
101 tests on different browsers, and automatically runs the linter as well. 101 tests on different browsers, and automatically run the linter as well.
102 102
103 On Windows, in order to use the test runner, in addition to setting up a Linux 103 On Windows, in order to use the test runner, in addition to setting up a Linux
104 environment as outlined above, you need to have Node.js installed in your native 104 environment as outlined above, you need to have Node.js installed in your native
105 Windows environment. Then run the commands below from within PowerShell or 105 Windows environment. Then run the commands below from within PowerShell or
106 cmd.exe (unlike when building the extension which needs to be done from Bash). 106 cmd.exe (unlike when building the extension which needs to be done from Bash).
107 107
108 Make sure the required packages are installed and up-to-date: 108 Make sure the required packages are installed and up-to-date:
109 109
110 npm install 110 npm install
111 111
(...skipping 12 matching lines...) Expand all
124 124
125 You will need to setup first. This will install our configuration 125 You will need to setup first. This will install our configuration
126 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) 126 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
127 and everything needed after you run: 127 and everything needed after you run:
128 128
129 npm install 129 npm install
130 130
131 Then you can run to lint the code: 131 Then you can run to lint the code:
132 132
133 npm run lint 133 npm run lint
LEFTRIGHT
« no previous file | package.json » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld