Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(259)

Issue 29890620: Noissue - Simplified qunit test wrapper (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by Sebastian Noack
Modified:
11 months ago
Reviewers:
tlucas
Visibility:
Public.

Description

Noissue - Simplified qunit test wrapper

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added missing semicolon #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M test/wrappers/qunit.js View 1 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit.js File test/wrappers/qunit.js (right): https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit.js#newcode27 test/wrappers/qunit.js:27: ).then(elem => .wait(until.elementLocated(...)) returns a promise that resolves with ...
11 months ago (2018-09-24 18:56:05 UTC) #1
tlucas
Can you please file an additional merge request on gitlab.com for this? Not as a ...
11 months ago (2018-09-25 12:24:45 UTC) #2
Sebastian Noack
There you go: https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31166535 The qunit tests still pass. However, the test pages fail. This, ...
11 months ago (2018-09-25 15:55:20 UTC) #3
Sebastian Noack
I fixed the issue that caused the test pages integration to fail. Here is the ...
11 months ago (2018-09-25 16:20:36 UTC) #4
tlucas
11 months ago (2018-09-25 17:03:52 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5