Noissue - Simplified qunit test wrapper

Noissue - Simplified qunit test wrapper

[Sebastian Noack, 2018-09-24 18:56:05]

https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit.js
File test/wrappers/qunit.js (right):

https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit...
test/wrappers/qunit.js:27: ).then(elem =>
.wait(until.elementLocated(...)) returns a promise that resolves with the
located element. So no need to look up that element again.

https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit...
test/wrappers/qunit.js:28: this.driver.wait(until.elementTextContains(elem,
"Tests completed"))
There is a pre-defined condition to wait for an element to contain a given text.
So no need to re-implement that logic.

https://codereview.adblockplus.org/29890620/diff/29890621/test/wrappers/qunit...
test/wrappers/qunit.js:31: elem => elem.getAttribute("textContent").then(name =>
assert.fail(name)),
Mocha only reports the first failure, it doesn't report multiple failures or
successful assertions. So we merely have to look for the first failed test.

[tlucas, 2018-09-25 12:24:45]

Can you please file an additional merge request on gitlab.com for this? Not as a
replacement for rietveld, but to trigger CI.

[Sebastian Noack, 2018-09-25 15:55:20]

There you go:
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31166535

The qunit tests still pass. However, the test pages fail. This, however, seems
unrelated of this change.

[Sebastian Noack, 2018-09-25 16:20:36]

I fixed the issue that caused the test pages integration to fail. Here is the
new pipeline for a branch that contains this change, that fix, and one more
change to the test automation currently under review:
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31168869

[tlucas, 2018-09-25 17:03:52]

LGTM