Noissue - Simplified qunit test wrapper

test/wrappers/qunit.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const {By, until} = require("selenium-webdriver");
 const assert = require("assert");
 
 it("qunit", function()
 {
   return this.driver.navigate().to(this.origin + "/qunit/index.html").then(() =>
-    // Wait for qunit-results to be present
     this.driver.wait(until.elementLocated(By.id("qunit-testresult")))
+  ).then(elem =>

[Sebastian Noack, 2018/09/24 18:56:05]

.wait(until.elementLocated(...)) returns a promise that resolves with the
located element. So no need to look up that element again.

+    this.driver.wait(until.elementTextContains(elem, "Tests completed"))

[Sebastian Noack, 2018/09/24 18:56:05]

There is a pre-defined condition to wait for an element to contain a given text.
So no need to re-implement that logic.

   ).then(() =>
-    // Wait for tests to finish
-    this.driver.wait(() =>
-      this.driver.findElement(By.id("qunit-testresult"))
-        .getAttribute("innerHTML").then(data =>
-           data.includes("Tests completed")))
-  ).then(() => Promise.all([[true, ".pass"], [false, ".fail"]].map(
-    ([success, sel]) => this.driver.findElements(
-      By.css(`#qunit-tests ${sel} .test-name`)
-    ).then(elements => Promise.all(elements.map(elem =>
-      elem.getAttribute("textContent").then(data => assert.ok(success, data))
-    )))
-  )));
+    this.driver.findElement(By.css("#qunit-tests .fail .test-name")).then(
+      elem => elem.getAttribute("textContent").then(name => assert.fail(name)),

[Sebastian Noack, 2018/09/24 18:56:05]

Mocha only reports the first failure, it doesn't report multiple failures or
successful assertions. So we merely have to look for the first failed test.

+      () => null
+    )
+  )
 });