Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29891645: Issue 5601 - Speed up static generation (Closed)

Created:
Sept. 25, 2018, 12:27 p.m. by Vasily Kuznetsov
Modified:
Sept. 28, 2018, 10:57 a.m.
Reviewers:
Jon Sonesen
Visibility:
Public.

Description

Issue 5601 - Speed up static generation Repository: https://hg.adblockplus.org/cms Base revision: 55a95d9ffd0d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M cms/converters.py View 1 chunk +1 line, -4 lines 0 comments Download
M cms/sources.py View 2 chunks +5 lines, -2 lines 1 comment Download
M tests/test_multi_source.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Vasily Kuznetsov
Hi Jon, This review contains the safe optimizations that reduce the running time of generate_static_pages ...
Sept. 25, 2018, 12:31 p.m. (2018-09-25 12:31:33 UTC) #1
Jon Sonesen
Sept. 27, 2018, 2:04 p.m. (2018-09-27 14:04:18 UTC) #2
Hey,

This is great :) Also, I think there is room for other optimizations which I
will likely file a ticket for soon.

LGTM!

Powered by Google App Engine
This is Rietveld