Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 29891666: Noissue - Enable tests to run on other browser versions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by Sebastian Noack
Modified:
10 months, 4 weeks ago
Reviewers:
tlucas
CC:
rossg
Visibility:
Public.

Description

Noissue - Enable tests to run on other browser versions

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -22 lines) Patch
M README.md View 1 chunk +13 lines, -0 lines 2 comments Download
M test/all.js View 2 chunks +19 lines, -1 line 2 comments Download
M test/browsers/chromium.js View 1 chunk +7 lines, -11 lines 0 comments Download
M test/browsers/firefox.js View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Pipeline is here (and includes both changes currently under review): https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31184783
11 months ago (2018-09-25 19:54:06 UTC) #1
tlucas
https://codereview.adblockplus.org/29891666/diff/29891672/README.md File README.md (right): https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120 README.md:120: By default it downloads (and caches) the oldest compatible ...
11 months ago (2018-09-26 08:20:17 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29891666/diff/29891672/README.md File README.md (right): https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120 README.md:120: By default it downloads (and caches) the oldest compatible ...
11 months ago (2018-09-26 11:00:21 UTC) #3
tlucas
10 months, 4 weeks ago (2018-09-26 18:21:04 UTC) #4
On 2018/09/26 11:00:21, Sebastian Noack wrote:
> https://codereview.adblockplus.org/29891666/diff/29891672/README.md
> File README.md (right):
> 
> https://codereview.adblockplus.org/29891666/diff/29891672/README.md#newcode120
> README.md:120: By default it downloads (and caches) the oldest compatible
> version
> On 2018/09/26 08:20:16, tlucas wrote:
> > While at it, what do you think about defaulting to "installed" when run
> locally
> > and explicitly defining the versions to be downloaded for CI in the
> > .gitlab-ci.yml file?
> 
> Developers should still make sure everything works on the oldest version, when
> testing locally. I thought about running tests both on the oldest compatible
> version, and the installed one (if any). But I keep this for another change.
> 
> https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js
> File test/all.js (right):
> 
>
https://codereview.adblockplus.org/29891666/diff/29891672/test/all.js#newcode36
> test/all.js:36: version = spec.substr(9);
> On 2018/09/26 08:20:16, tlucas wrote:
> > Are we ok with not checking whether someone tries to donwload a version
older
> > then the latest compatible?
> 
> I am. Since this needs to be explicitly requested, I assume people to know
what
> they do, and rather keep this change simple.

Alright - LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5