Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(245)

Issue 29891677: Noissue - Make subscribe link tests more reliable by waiting for options page to be ready (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Sebastian Noack
Modified:
1 year, 2 months ago
Reviewers:
hub, tlucas
Visibility:
Public.

Description

Noissue - Make subscribe link tests more reliable by waiting for options page to be ready

Patch Set 1 #

Total comments: 3

Patch Set 2 : Increased timeout for options page tab as requested by Ross #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M test/wrappers/pages.js View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Pipeline is here (and includes both changes currently under review): https://gitlab.com/eyeo/adblockplus/adblockpluschrome/pipelines/31184783
1 year, 2 months ago (2018-09-25 19:53:19 UTC) #1
hub
LGTM
1 year, 2 months ago (2018-09-25 22:23:04 UTC) #2
tlucas
https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js File test/wrappers/pages.js (right): https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js#newcode61 test/wrappers/pages.js:61: driver.wait(until.ableToSwitchToFrame(0), 1000).then(() => In order to not reject subscriptions, ...
1 year, 2 months ago (2018-09-26 08:28:17 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js File test/wrappers/pages.js (right): https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js#newcode61 test/wrappers/pages.js:61: driver.wait(until.ableToSwitchToFrame(0), 1000).then(() => On 2018/09/26 08:28:17, tlucas wrote: > ...
1 year, 2 months ago (2018-09-26 11:07:36 UTC) #4
tlucas
1 year, 2 months ago (2018-09-26 18:19:41 UTC) #5
LGTM

https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages.js
File test/wrappers/pages.js (right):

https://codereview.adblockplus.org/29891677/diff/29891678/test/wrappers/pages...
test/wrappers/pages.js:61: driver.wait(until.ableToSwitchToFrame(0),
1000).then(() =>
On 2018/09/26 11:07:36, Sebastian Noack wrote:
> On 2018/09/26 08:28:17, tlucas wrote:
> > In order to not reject subscriptions, which might take longer (in case that
> > could happen), "wait()" should be called without a timeout IMHO.
> > Same below.
> 
> But if there is a bug (caught by this test) with the subscription links, then
> the tests would never complete rather than failing.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5