Issue 6986 - Don't use chromium remote interface on Windows

test/runners/chromium_remote_process.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
     fs.rmdirSync(dirPath);
   }
   catch (error)
   {
     console.error(error);
   }
 }
 
 function startChromium(chromiumPath)
 {
-  fs.chmodSync(chromiumPath, fs.constants.S_IRWXU);
+  fs.chmodSync(chromiumPath, 0o700);

[Sebastian Noack, 2018/09/25 22:12:46]

fs.constants.S_IRWXU is 0o700. This change has no effect as far as I can tell.

[hub, 2018/09/26 01:03:25]

on Windows? I expect it to be undefined there.

[Sebastian Noack, 2018/09/26 01:10:51]

Geo, can you confirm?

[geo, 2018/09/26 13:34:09]

Well, it get's rid of the `fs.chmodSync` error. However now I'm having a
different error.

`
Error: The geckodriver.exe executable could not be found on the current PATH.
Please download the latest version from
https://github.com/mozilla/geckodriver/releases/ and ensure it can be found on
your PATH.
    at findGeckoDriver
(C:\Work\new\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\firefox\index.js:354:11)
    at new ServiceBuilder
(C:\Work\new\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\firefox\index.js:446:22)
    at Function.createSession
(C:\Work\new\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\firefox\index.js:516:21)
    at createDriver
(C:\Work\new\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\index.js:170:33)
    at Builder.build
(C:\Work\new\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\index.js:645:16)
    at runScript
(C:\Work\new\adblockpluschrome\adblockpluscore\test\runners\firefox_process.js:42:10)
    at ensureFirefox.then.firefoxPath
(C:\Work\new\adblockpluschrome\adblockpluscore\test\runners\firefox_process.js:51:12)
    at <anonymous>
`

On different clones of the repo, I'm not getting the error that I've reported,
but instead:

`
C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\lib\promise.js:2626
        throw error;
        ^

SessionNotCreatedError: Failed to start browser
C:\Work\adblockpluschrome\adblockpluscore\firefox-snapshots\firefox-win32-x64-57.0\firefox.exe:
no such file or directory
    at Object.throwDecodedError
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\lib\error.js:514:15)
    at parseHttpResponse
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\lib\http.js:519:13)
    at doSend.then.response
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\lib\http.js:441:30)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
From: Task: WebDriver.createSession()
    at Function.createSession
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\lib\webdriver.js:769:24)
    at Function.createSession
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\firefox\index.js:521:41)
    at createDriver
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\index.js:170:33)
    at Builder.build
(C:\Work\adblockpluschrome\adblockpluscore\node_modules\selenium-webdriver\index.js:645:16)
    at runScript
(C:\Work\adblockpluschrome\adblockpluscore\test\runners\firefox_process.js:42:10)
    at ensureFirefox.then.firefoxPath
(C:\Work\adblockpluschrome\adblockpluscore\test\runners\firefox_process.js:51:12)
    at <anonymous>
`

Kinda seems the same issue.

 
   let dataDir = fs.mkdtempSync(path.join(os.tmpdir(), "chromium-data"));
   let child = null;
   return {
     kill: () => child && child.kill(),
     done: new Promise((resolve, reject) =>
     {
       child = childProcess.execFile(chromiumPath, [
         "--headless", "--single-process", "--disable-gpu", "--no-sandbox",
         "--allow-file-access-from-files", "--remote-debugging-port=9222",
@@ skipping 135 matching lines @@
     {
       child.kill();
       return result;
     }).catch(error =>
     {
       child.kill();
       throw error;
     });
   });
 };