Unified Diff: test_runner.js
Issue 29891680:
Issue 6986 - Don't use chromium remote interface on Windows (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Removed the changes in chrome_remote_interface
Created Nov. 9, 2018, 8:02 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« test/runners/chromium_process.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test_runner.js |
| =================================================================== |
| --- a/test_runner.js |
| +++ b/test_runner.js |
| @@ -42,17 +42,23 @@ |
| }; |
| function configureRunners() |
| { |
| let runners = "BROWSER_TEST_RUNNERS" in process.env ? |
| process.env.BROWSER_TEST_RUNNERS.split(",") : []; |
| if (runners.length == 0) |
| + { |
| + // We default to not using the Chromium remote interface on Windows, |
| + // as it fails. |
| + if (process.platform == "win32") |
| + return ["chromium", "firefox"]; |
| return ["chromium_remote", "firefox"]; |
| + } |
| return runners.filter(runner => runnerDefinitions.hasOwnProperty(runner)); |
| } |
| let runnerProcesses = configureRunners(); |
| function addTestPaths(testPaths, recurse) |
| { |
« no previous file with comments
|
« test/runners/chromium_process.js ('k')
|
no next file »
|
no next file with comments »
