Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29892566: Noissue - Use for...of in tabs.onActivated handler (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Sept. 26, 2018, 4:40 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -448,27 +448,27 @@
if (tabs.length == 0)
return;
let items = contextMenuItems.get({id: tabs[0].id});
if (!items)
return;
- items.forEach(item =>
+ for (let item of items)
{
browser.contextMenus.create({
title: item.title,
contexts: item.contexts,
onclick(info, tab)
{
item.onclick(new Page(tab));
}
});
- });
+ }
});
});
};
let ContextMenus = function(page)
{
this._page = page;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld