Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterClasses.js

Issue 29892579: Noissue - Do not pass sitekeys to ActiveFilter constructor (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Sept. 26, 2018, 8:39 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 * Defines whether the filter should apply to third-party or first-party 640 * Defines whether the filter should apply to third-party or first-party
641 * content only 641 * content only
642 * @param {string} [sitekeys] 642 * @param {string} [sitekeys]
643 * Public keys of websites that this filter should apply to 643 * Public keys of websites that this filter should apply to
644 * @constructor 644 * @constructor
645 * @augments ActiveFilter 645 * @augments ActiveFilter
646 */ 646 */
647 function RegExpFilter(text, regexpSource, contentType, matchCase, domains, 647 function RegExpFilter(text, regexpSource, contentType, matchCase, domains,
648 thirdParty, sitekeys) 648 thirdParty, sitekeys)
649 { 649 {
650 ActiveFilter.call(this, text, domains, sitekeys); 650 ActiveFilter.call(this, text, domains);
651 651
652 if (contentType != null) 652 if (contentType != null)
653 this.contentType = contentType; 653 this.contentType = contentType;
654 if (matchCase) 654 if (matchCase)
655 this.matchCase = matchCase; 655 this.matchCase = matchCase;
656 if (thirdParty != null) 656 if (thirdParty != null)
657 this.thirdParty = thirdParty; 657 this.thirdParty = thirdParty;
658 if (sitekeys != null) 658 if (sitekeys != null)
659 this.sitekeySource = sitekeys; 659 this.sitekeySource = sitekeys;
660 660
(...skipping 570 matching lines...) Expand 10 before | Expand all | Expand 10 after
1231 1231
1232 /** 1232 /**
1233 * Script that should be executed 1233 * Script that should be executed
1234 * @type {string} 1234 * @type {string}
1235 */ 1235 */
1236 get script() 1236 get script()
1237 { 1237 {
1238 return this.body; 1238 return this.body;
1239 } 1239 }
1240 }); 1240 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld