Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(291)

Issue 29892585: Issue 6985 - Running npm test fails on Windows for adblockpluschrome (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by geo
Modified:
1 year, 2 months ago
Reviewers:
Sebastian Noack, tlucas
Visibility:
Public.

Description

Issue 6985 - Running npm test fails on Windows for adblockpluschrome

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M test/browsers/chromium.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/browsers/firefox.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
geo
`npm test -- -g gecko` is still going to fail until we update the adblockpluscore ...
1 year, 2 months ago (2018-09-26 21:29:43 UTC) #1
Sebastian Noack
On 2018/09/26 21:29:43, geo wrote: > `npm test -- -g gecko` is still going to ...
1 year, 2 months ago (2018-09-26 21:38:52 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29892585/diff/29892586/test/browsers/chromium.js File test/browsers/chromium.js (right): https://codereview.adblockplus.org/29892585/diff/29892586/test/browsers/chromium.js#newcode24 test/browsers/chromium.js:24: require("chromedriver"); I'd add a comment that this is necessary ...
1 year, 2 months ago (2018-09-26 21:38:57 UTC) #3
geo
I've updated the dependencies as suggested. https://codereview.adblockplus.org/29892585/diff/29892586/test/browsers/chromium.js File test/browsers/chromium.js (right): https://codereview.adblockplus.org/29892585/diff/29892586/test/browsers/chromium.js#newcode24 test/browsers/chromium.js:24: require("chromedriver"); On 2018/09/26 ...
1 year, 2 months ago (2018-09-26 22:20:28 UTC) #4
Sebastian Noack
LGTM
1 year, 2 months ago (2018-09-26 22:22:43 UTC) #5
tlucas
1 year, 2 months ago (2018-09-27 09:06:09 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5