test/browsers/chromium.js - Issue 29892585: Issue 6985 - Running npm test fails on Windows for adblockpluschrome

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/browsers/chromium.js

Issue 29892585: Issue 6985 - Running npm test fails on Windows for adblockpluschrome (Closed)

Patch Set: Created Sept. 26, 2018, 9:18 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/browsers/chromium.js

diff --git a/test/browsers/chromium.js b/test/browsers/chromium.js

index 9672237cd704441d113711a0fc192efabed3af00..7f670fc29a3cb267e6fa0c6cdc5584a7e2fdb4d0 100644

--- a/test/browsers/chromium.js

+++ b/test/browsers/chromium.js

@@ -21,6 +21,7 @@ const webdriver = require("selenium-webdriver");

const chrome = require("selenium-webdriver/chrome");

const {ensureChromium} = require("../../adblockpluscore/test/runners/" +

"chromium_download");

+require("chromedriver");

Sebastian Noack 2018/09/26 21:38:57 I'd add a comment that this is necessary on Window

geo 2018/09/26 22:20:28 Done.

exports.platform = "chrome";

exports.ensureBrowser = ensureChromium;

« no previous file with comments | « no previous file | test/browsers/firefox.js » ('j') | no next file with comments »