Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browsers/firefox.js

Issue 29892585: Issue 6985 - Running npm test fails on Windows for adblockpluschrome (Closed)
Patch Set: Created Sept. 26, 2018, 10:18 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browsers/firefox.js
diff --git a/test/browsers/firefox.js b/test/browsers/firefox.js
index 2aa18c13a58d435fac50cacd4ba4ffb58b792599..b2109eb99140b118be1bdfa568927689825b9ef3 100644
--- a/test/browsers/firefox.js
+++ b/test/browsers/firefox.js
@@ -23,6 +23,10 @@ const {Command} = require("selenium-webdriver/lib/command");
const {ensureFirefox} = require("../../adblockpluscore/test/runners/" +
"firefox_download");
+// We need to require the geckodriver,
+// otherwise on Windows the geckodriver path is not added to process.env.PATH.
+require("geckodriver");
+
exports.platform = "gecko";
exports.oldestCompatibleVersion = "57.0";
exports.ensureBrowser = ensureFirefox;
« no previous file with comments | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld