Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 29893555: Issue 6997 - Use createStyleSheet implementation from core (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Manish Jethani
Modified:
1 year ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Update dependency to 0a316e60de4e #

Patch Set 3 : Revert to PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M dependencies View 2 1 chunk +1 line, -1 line 0 comments Download
M lib/contentFiltering.js View 2 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
1 year ago (2018-09-27 05:10:44 UTC) #1
Manish Jethani
Patch Set 1 This is on the next bookmark, includes a dependency update to core's ...
1 year ago (2018-09-27 05:11:31 UTC) #2
Sebastian Noack
Looks good to me once there is an issue for the dependency update, and we ...
1 year ago (2018-09-27 15:28:35 UTC) #3
Manish Jethani
On 2018/09/27 15:28:35, Sebastian Noack wrote: > Looks good to me once there is an ...
1 year ago (2018-09-27 17:14:54 UTC) #4
Manish Jethani
Patch Set 2: Update dependency to 0a316e60de4e Landed one more change, might as well include ...
1 year ago (2018-09-27 17:25:25 UTC) #5
Sebastian Noack
LGTM
1 year ago (2018-09-27 20:03:48 UTC) #6
Manish Jethani
On 2018/09/27 20:03:48, Sebastian Noack wrote: > LGTM Thanks. Actually Patch Set 2 won't work ...
1 year ago (2018-09-27 21:22:13 UTC) #7
Sebastian Noack
1 year ago (2018-09-27 21:59:39 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5