Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/contentFiltering.js

Issue 29893559: Issue 6999 - Generate style sheets in background page (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Remove individual rule injection Created Sept. 28, 2018, 8:15 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include.preload.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 return; 90 return;
91 91
92 browser.tabs.removeCSS(tabId, { 92 browser.tabs.removeCSS(tabId, {
93 code: styleSheet, 93 code: styleSheet,
94 cssOrigin: "user", 94 cssOrigin: "user",
95 frameId, 95 frameId,
96 matchAboutBlank: true 96 matchAboutBlank: true
97 }); 97 });
98 } 98 }
99 99
100 function updateFrameStyles(tabId, frameId, selectors, groupName, appendOnly) 100 function updateFrameStyles(tabId, frameId, styleSheet, groupName = "standard",
101 appendOnly = false)
101 { 102 {
102 let styleSheet = "";
103 if (selectors.length > 0)
104 styleSheet = createStyleSheet(selectors);
105
106 let frame = ext.getFrame(tabId, frameId); 103 let frame = ext.getFrame(tabId, frameId);
107 if (!frame) 104 if (!frame)
108 return false; 105 return false;
109 106
110 if (!frame.injectedStyleSheets) 107 if (!frame.injectedStyleSheets)
111 frame.injectedStyleSheets = new Map(); 108 frame.injectedStyleSheets = new Map();
112 109
113 let oldStyleSheet = frame.injectedStyleSheets.get(groupName); 110 let oldStyleSheet = frame.injectedStyleSheets.get(groupName);
114 111
115 if (appendOnly && oldStyleSheet) 112 if (appendOnly && oldStyleSheet)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 { 184 {
188 // See the comment in the catch block associated with the call to 185 // See the comment in the catch block associated with the call to
189 // tabs.insertCSS for why we catch any error here and simply 186 // tabs.insertCSS for why we catch any error here and simply
190 // return a rejected promise. 187 // return a rejected promise.
191 return Promise.reject(error); 188 return Promise.reject(error);
192 } 189 }
193 } 190 }
194 191
195 port.on("content.applyFilters", (message, sender) => 192 port.on("content.applyFilters", (message, sender) =>
196 { 193 {
194 let styleSheet = "";
197 let selectors = []; 195 let selectors = [];
198 let emulatedPatterns = []; 196 let emulatedPatterns = [];
199 let trace = HitLogger.hasListener(sender.page.id); 197 let trace = HitLogger.hasListener(sender.page.id);
200 let inline = !userStyleSheetsSupported; 198 let inline = !userStyleSheetsSupported;
201 199
202 let {elemhide, snippets} = message.filterTypes || 200 let {elemhide, snippets} = message.filterTypes ||
203 {elemhide: true, snippets: true}; 201 {elemhide: true, snippets: true};
204 202
205 if (!checkWhitelisted(sender.page, sender.frame, null, 203 if (!checkWhitelisted(sender.page, sender.frame, null,
206 RegExpFilter.typeMap.DOCUMENT)) 204 RegExpFilter.typeMap.DOCUMENT))
(...skipping 18 matching lines...) Expand all
225 }); 223 });
226 } 224 }
227 } 225 }
228 226
229 if (elemhide && !checkWhitelisted(sender.page, sender.frame, null, 227 if (elemhide && !checkWhitelisted(sender.page, sender.frame, null,
230 RegExpFilter.typeMap.ELEMHIDE)) 228 RegExpFilter.typeMap.ELEMHIDE))
231 { 229 {
232 let specificOnly = checkWhitelisted(sender.page, sender.frame, null, 230 let specificOnly = checkWhitelisted(sender.page, sender.frame, null,
233 RegExpFilter.typeMap.GENERICHIDE); 231 RegExpFilter.typeMap.GENERICHIDE);
234 selectors = ElemHide.getSelectorsForDomain(docDomain, specificOnly); 232 selectors = ElemHide.getSelectorsForDomain(docDomain, specificOnly);
233 styleSheet = createStyleSheet(selectors);
235 234
236 for (let filter of ElemHideEmulation.getRulesForDomain(docDomain)) 235 for (let filter of ElemHideEmulation.getRulesForDomain(docDomain))
237 emulatedPatterns.push({selector: filter.selector, text: filter.text}); 236 emulatedPatterns.push({selector: filter.selector, text: filter.text});
238 } 237 }
239 } 238 }
240 239
241 if (!inline && !updateFrameStyles(sender.page.id, sender.frame.id, 240 if (!inline && !updateFrameStyles(sender.page.id, sender.frame.id,
242 selectors, "standard")) 241 styleSheet))
243 { 242 {
244 inline = true; 243 inline = true;
245 } 244 }
246 245
247 let response = {trace, inline, emulatedPatterns}; 246 let response = {trace, inline, emulatedPatterns};
248 if (trace || inline) 247
248 if (inline)
249 response.styleSheet = styleSheet;
250
251 if (trace)
249 response.selectors = selectors; 252 response.selectors = selectors;
250 253
251 return response; 254 return response;
252 }); 255 });
253 256
254 port.on("content.injectSelectors", (message, sender) => 257 port.on("content.injectSelectors", (message, sender) =>
255 { 258 {
256 updateFrameStyles(sender.page.id, sender.frame.id, message.selectors, 259 updateFrameStyles(sender.page.id, sender.frame.id,
260 createStyleSheet(message.selectors),
257 message.groupName, message.appendOnly); 261 message.groupName, message.appendOnly);
258 }); 262 });
259 263
260 fetch(browser.extension.getURL("/snippets.js"), {cache: "no-cache"}) 264 fetch(browser.extension.getURL("/snippets.js"), {cache: "no-cache"})
261 .then(response => response.ok ? response.text() : "") 265 .then(response => response.ok ? response.text() : "")
262 .then(text => 266 .then(text =>
263 { 267 {
264 snippetsLibrarySource = text; 268 snippetsLibrarySource = text;
265 }); 269 });
OLDNEW
« no previous file with comments | « include.preload.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld