Issue 29893628: Issue 6957 - Skip selector lookup for unknown domains

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29893628: Issue 6957 - Skip selector lookup for unknown domains (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year ago by Manish Jethani

Modified:
1 year ago

Reviewers:
Jon Sonesen, hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

More Reviews

Description

Based on https://codereview.adblockplus.org/29893618/ The extension doesn't need a separate list of selectors unless DevTools is open, and we don't need to look up the selectors for a specific domain if the domain is unknown (we already have the common style sheet). This patch speeds up the function for unknown domains by another ~80%.

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 1 year ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -7 lines)			Patch
	M	lib/elemHide.js	View	1	2 chunks	+19 lines, -6 lines	0 comments	Download
	M	test/elemHide.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages