Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(182)

Issue 29893628: Issue 6957 - Skip selector lookup for unknown domains (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Manish Jethani
Modified:
1 year ago
Reviewers:
Jon Sonesen, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29893618/ The extension doesn't need a separate list of selectors unless DevTools is open, and we don't need to look up the selectors for a specific domain if the domain is unknown (we already have the common style sheet). This patch speeds up the function for unknown domains by another ~80%.

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M lib/elemHide.js View 1 2 chunks +19 lines, -6 lines 0 comments Download
M test/elemHide.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
1 year ago (2018-09-27 22:01:17 UTC) #1
Manish Jethani
Patch Set 1 Please see the description.
1 year ago (2018-09-27 22:04:28 UTC) #2
hub
LGTM
1 year ago (2018-09-28 16:37:41 UTC) #3
Manish Jethani
Patch Set 2: Rebase
1 year ago (2018-09-28 18:01:39 UTC) #4
hub
1 year ago (2018-09-28 18:05:19 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5