Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29894561: Issue 6998 - Stop using Shadow DOM v0 (Closed)

Created:
Sept. 28, 2018, 11:14 a.m. by Manish Jethani
Modified:
Sept. 28, 2018, 12:54 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove splitSelector import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -61 lines) Patch
M include.preload.js View 1 2 chunks +8 lines, -61 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
Sept. 28, 2018, 11:14 a.m. (2018-09-28 11:14:53 UTC) #1
Manish Jethani
Patch Set 1
Sept. 28, 2018, 11:16 a.m. (2018-09-28 11:16:13 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29894561/diff/29894562/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29894561/diff/29894562/include.preload.js#newcode20 include.preload.js:20: let {splitSelector} = require("./adblockpluscore/lib/common"); It seems this import is ...
Sept. 28, 2018, 12:38 p.m. (2018-09-28 12:38:16 UTC) #3
Manish Jethani
Patch Set 2: Remove splitSelector import https://codereview.adblockplus.org/29894561/diff/29894562/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29894561/diff/29894562/include.preload.js#newcode20 include.preload.js:20: let {splitSelector} = ...
Sept. 28, 2018, 12:40 p.m. (2018-09-28 12:40:39 UTC) #4
Sebastian Noack
Sept. 28, 2018, 12:42 p.m. (2018-09-28 12:42:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld