Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)

Issue 29894564: Issue 6999 - Remove inlineEmulated flag in content.applyFilters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Manish Jethani
Modified:
1 year ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Based on (but unrelated to) https://codereview.adblockplus.org/29894561/

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M include.preload.js View 1 3 chunks +2 lines, -9 lines 2 comments Download
M lib/contentFiltering.js View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
1 year ago (2018-09-28 11:44:31 UTC) #1
Manish Jethani
Patch Set 1
1 year ago (2018-09-28 11:45:28 UTC) #2
Manish Jethani
On 2018/09/28 11:45:28, Manish Jethani wrote: > Patch Set 1 What about this one?
1 year ago (2018-09-28 19:38:03 UTC) #3
Manish Jethani
Patch Set 2: Rebase
1 year ago (2018-09-28 19:40:39 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js#newcode403 include.preload.js:403: () => {}, It seems if ElemHideEmulation is no ...
1 year ago (2018-09-29 00:18:47 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js#newcode403 include.preload.js:403: () => {}, On 2018/09/29 00:18:47, Sebastian Noack wrote: ...
1 year ago (2018-09-29 01:58:50 UTC) #6
Sebastian Noack
1 year ago (2018-09-29 02:06:00 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5