Issue 29894564: Issue 6999 - Remove inlineEmulated flag in content.applyFilters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29894564: Issue 6999 - Remove inlineEmulated flag in content.applyFilters (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year, 2 months ago by Manish Jethani

Modified:
1 year, 2 months ago

Reviewers:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/adblockpluschrome/

Visibility:
Public.

More Reviews

Description

Based on (but unrelated to) https://codereview.adblockplus.org/29894561/

Patch Set 2 : Rebase #

Total comments: 2

Created: 1 year, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
	M	include.preload.js	View	1	3 chunks	+2 lines, -9 lines	2 comments	Download
	M	lib/contentFiltering.js	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Manish Jethani

On 2018/09/28 11:45:28, Manish Jethani wrote: > Patch Set 1 What about this one?

1 year, 2 months ago (2018-09-28 19:38:03 UTC) #3

Sebastian Noack

https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29894564/diff/29894598/include.preload.js#newcode403 include.preload.js:403: () => {}, It seems if ElemHideEmulation is no ...

1 year, 2 months ago (2018-09-29 00:18:47 UTC) #5

Manish Jethani

1 year, 2 months ago (2018-09-29 01:58:50 UTC) #6

LGTM

Expand All Messages | Collapse All Messages