Issue 6999 - Remove inlineEmulated flag in content.applyFilters

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {splitSelector} = require("./adblockpluscore/lib/common");
 let {ElemHideEmulation} =
   require("./adblockpluscore/lib/content/elemHideEmulation");
 
 // This variable is also used by our other content scripts.
 let contentFiltering;
 
 const typeMap = new Map([
   ["img", "IMAGE"],
   ["input", "IMAGE"],
   ["picture", "IMAGE"],
@@ skipping 363 matching lines @@
   }
 };
 
 function ContentFiltering()
 {
   this.styles = new Map();
   this.tracer = null;
   this.inline = true;
 
   this.elemHideEmulation = new ElemHideEmulation(
     () => {},

[Sebastian Noack, 2018/09/29 00:18:47]

It seems if ElemHideEmulation is no longer call addSelectors(), the second
argument (filters) and the related logic is redundant now.

Also if we go there, we might want to remove this argument to the
ElemHideEmulation() constructor altogether with
https://codereview.adblockplus.org/29884580, after which (as of the current
patch set), it would never be called anymore anyway.

[Manish Jethani, 2018/09/29 01:58:50]

Let's make this change part of https://codereview.adblockplus.org/29893559/
(it's already in there).
Alright, so the parameter is now removed, but we're doing a dependency update in
https://codereview.adblockplus.org/29893559/ so I can leave this here for now.

Unless you want me to merge the two patches.

     this.hideElements.bind(this)
   );
 }
 ContentFiltering.prototype = {
   selectorGroupSize: 1024,
 
   addSelectorsInline(selectors, groupName, appendOnly = false)
   {
     let style = this.styles.get(groupName);
 
@@ skipping 55 matching lines @@
       // Once all supported platforms have implemented this API, we can remove
       // the code below. See issue #5090.
       // Related Chrome and Firefox issues:
       // https://bugs.chromium.org/p/chromium/issues/detail?id=632009
       // https://bugzilla.mozilla.org/show_bug.cgi?id=1310026
       this.addSelectorsInline(selectors, groupName, appendOnly);
     }
     else
     {
       browser.runtime.sendMessage({
-        type: "elemhide.injectSelectors",
+        type: "content.injectSelectors",
         selectors,
         groupName,
         appendOnly
       });
     }
 
     // Only trace selectors that are based directly on hiding filters
     // (i.e. leave out collapsing selectors).
     if (this.tracer && groupName != "collapsing")
       this.tracer.addSelectors(selectors, filters);
@@ skipping 59 matching lines @@
     let element = event.target;
     if (/^i?frame$/.test(element.localName))
       checkCollapse(element);
   }, true);
 }
 
 window.checkCollapse = checkCollapse;
 window.contentFiltering = contentFiltering;
 window.typeMap = typeMap;
 window.getURLsFromElement = getURLsFromElement;