Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29894568: Issue 6999 - Generate style sheets in background page (Closed)

Created:
Sept. 28, 2018, 12:27 p.m. by Manish Jethani
Modified:
Sept. 28, 2018, 1:23 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29894564/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -21 lines) Patch
M include.preload.js View 2 chunks +38 lines, -13 lines 0 comments Download
M lib/contentFiltering.js View 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
Sept. 28, 2018, 12:27 p.m. (2018-09-28 12:27:40 UTC) #1
Manish Jethani
Patch Set 1
Sept. 28, 2018, 12:27 p.m. (2018-09-28 12:27:57 UTC) #2
Manish Jethani
On 2018/09/28 12:27:57, Manish Jethani wrote: > Patch Set 1 We could do some renaming ...
Sept. 28, 2018, 12:29 p.m. (2018-09-28 12:29:55 UTC) #3
Manish Jethani
Sept. 28, 2018, 1:23 p.m. (2018-09-28 13:23:33 UTC) #4
On 2018/09/28 12:29:55, Manish Jethani wrote:
> On 2018/09/28 12:27:57, Manish Jethani wrote:
> > Patch Set 1
> 
> We could do some renaming and refactoring here but let's discuss it.

Sorry, I'm merging this into https://codereview.adblockplus.org/29893559

Powered by Google App Engine
This is Rietveld