Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(455)

Issue 29894584: Issue 6948 - Begun simplifying the "block element" context menu logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by kzar
Modified:
1 year, 4 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 6948 - Begun simplifying the "block element" context menu logic

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -145 lines) Patch
M ext/background.js View 2 chunks +0 lines, -85 lines 0 comments Download
M lib/filterComposer.js View 3 chunks +87 lines, -60 lines 4 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
1 year, 4 months ago (2018-09-28 15:22:55 UTC) #1
kzar
So far I've just smoke tested this on Chrome, and it already fixes the issue ...
1 year, 4 months ago (2018-09-28 15:37:35 UTC) #2
Sebastian Noack
I cannot see any obvious issues with that change, and it's always great to get ...
1 year, 4 months ago (2018-09-28 16:24:25 UTC) #3
kzar
On 2018/09/28 16:24:25, Sebastian Noack wrote: > I cannot see any obvious issues with that ...
1 year, 4 months ago (2018-10-01 11:38:54 UTC) #4
Sebastian Noack
1 year, 4 months ago (2018-10-01 11:48:39 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5