Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29895567: Noissue - Avoid access to stack trace unless necessary (Closed)

Created:
Sept. 29, 2018, 1:37 p.m. by Manish Jethani
Modified:
Sept. 29, 2018, 4:59 p.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Avoid access to stack trace unless necessary

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move declaration #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M polyfill.js View 1 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 7
Manish Jethani
Sept. 29, 2018, 1:37 p.m. (2018-09-29 13:37:07 UTC) #1
Manish Jethani
Patch Set 1 Profiling the extension, some odd things stand out. One of these things ...
Sept. 29, 2018, 1:39 p.m. (2018-09-29 13:39:13 UTC) #2
Sebastian Noack
It feels a little backwards to me to optimize for a use case that we ...
Sept. 29, 2018, 1:53 p.m. (2018-09-29 13:53:21 UTC) #3
Manish Jethani
Patch Set 2: Move declaration On 2018/09/29 13:53:21, Sebastian Noack wrote: > It feels a ...
Sept. 29, 2018, 3:49 p.m. (2018-09-29 15:49:11 UTC) #4
Sebastian Noack
On 2018/09/29 15:49:11, Manish Jethani wrote: > Patch Set 2: Move declaration > > On ...
Sept. 29, 2018, 4:07 p.m. (2018-09-29 16:07:14 UTC) #5
Manish Jethani
On 2018/09/29 16:07:14, Sebastian Noack wrote: > On 2018/09/29 15:49:11, Manish Jethani wrote: > > ...
Sept. 29, 2018, 4:39 p.m. (2018-09-29 16:39:08 UTC) #6
Sebastian Noack
Sept. 29, 2018, 4:42 p.m. (2018-09-29 16:42:23 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld