Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: polyfill.js

Issue 29895567: Noissue - Avoid access to stack trace unless necessary (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Sept. 29, 2018, 1:37 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: polyfill.js
===================================================================
--- a/polyfill.js
+++ b/polyfill.js
@@ -84,21 +84,21 @@
// If the property is not writable assigning it will fail, so we use
// Object.defineProperty here instead. Assuming the property isn't
// inherited its other attributes (e.g. enumerable) are preserved,
// except for accessor attributes (e.g. get and set) which are discarded
// since we're specifying a value.
Object.defineProperty(object, name, {
value(...args)
{
- let callStack = new Error().stack;
-
if (typeof args[args.length - 1] == "function")
return func.apply(object, args);
+ let callStack = new Error().stack;
Sebastian Noack 2018/09/29 13:53:21 Nit: Perhaps initialize this variable along the re
Manish Jethani 2018/09/29 15:49:10 Done.
+
// If the last argument is undefined, we drop it from the list assuming
// it stands for the optional callback. We must do this, because we have
// to replace it with our own callback. If we simply append our own
// callback to the list, it won't match the signature of the function
// and will cause an exception.
if (typeof args[args.length - 1] == "undefined")
args.pop();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld