Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(419)

Issue 29896562: Issue 7003 - Look up whitelist filter only if URL is blocked

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by Manish Jethani
Modified:
2 weeks, 5 days ago
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This is a PROOF OF CONCEPT.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M lib/matcher.js View 1 chunk +19 lines, -9 lines 1 comment Download

Messages

Total messages: 2
Manish Jethani
2 weeks, 5 days ago (2018-09-30 08:55:56 UTC) #1
Sebastian Noack
2 weeks, 5 days ago (2018-09-30 13:39:23 UTC) #2
https://codereview.adblockplus.org/29896562/diff/29896563/lib/matcher.js
File lib/matcher.js (left):

https://codereview.adblockplus.org/29896562/diff/29896563/lib/matcher.js#oldc...
lib/matcher.js:371: for (let i = 0, l = candidates.length; i < l; i++)
Any reason to not use for..of here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5