Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterListener.js

Issue 29897555: Issue 6940 - Use underscore prefixes lib/matcher.js (Closed)
Patch Set: Address PS6 comment Created Oct. 24, 2018, 6:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/matcher.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/filterListener.js
===================================================================
--- a/test/filterListener.js
+++ b/test/filterListener.js
@@ -59,19 +59,19 @@
callback();
};
function checkKnownFilters(test, text, expected)
{
let result = {};
for (let type of ["blacklist", "whitelist"])
{
- let matcher = defaultMatcher[type];
+ let matcher = defaultMatcher["_" + type];
let filters = [];
- for (let [keyword, set] of matcher.filterByKeyword)
+ for (let [keyword, set] of matcher._filterByKeyword)
{
for (let filter of set)
{
test.equal(matcher.findKeyword(filter), keyword,
"Keyword of filter " + filter.text);
filters.push(filter.text);
}
}
« no previous file with comments | « lib/matcher.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld