Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(242)

Issue 29897558: Issue 6957 - Add rulesFromStyleSheet function to ElemHide module (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Manish Jethani
Modified:
1 year, 2 months ago
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

It seems the extension needs to inject individual style rules in the content script (using `insertRule` [1]), simply assigning the `textContent` property of the style element is not an option. In that case, we can simply return individual rules from our generated style sheet. The extension should only call this function if the platform does not support user style sheets. [1]: https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleSheet/insertRule

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M lib/elemHide.js View 1 chunk +23 lines, -0 lines 0 comments Download
M test/elemHide.js View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
1 year, 2 months ago (2018-10-01 14:57:00 UTC) #1
Manish Jethani
Patch Set 1
1 year, 2 months ago (2018-10-01 15:00:28 UTC) #2
hub
It would be nice to have an actual use for this in the WebExt in ...
1 year, 2 months ago (2018-10-01 18:44:15 UTC) #3
Manish Jethani
On 2018/10/01 18:44:15, hub wrote: > It would be nice to have an actual use ...
1 year, 2 months ago (2018-10-01 19:57:20 UTC) #4
Manish Jethani
On 2018/10/01 19:57:20, Manish Jethani wrote: > On 2018/10/01 18:44:15, hub wrote: > > It ...
1 year, 2 months ago (2018-10-02 08:19:20 UTC) #5
hub
1 year, 2 months ago (2018-10-02 13:15:45 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5