Issue 6996 - Fix -c option

hgreview.py

 import BaseHTTPServer
 import os
 import re
 import socket
 import sys
 import urllib
 
 from mercurial import cmdutil, error
 
 SERVER = 'https://codereview.adblockplus.org'
@@ skipping 34 matching lines @@
     elif ui.quiet:
         args.append('--quiet')
 
     if (not opts.get('no_mail') and
         (not opts.get('issue') or opts.get('message'))):
         args.append('--send_mail')
 
     if opts.get('revision') and opts.get('change'):
         raise error.Abort('Ambiguous revision range, only one of --revision and --change can be specified.')
     if opts.get('change'):
-        try:
-            rev_no = int(opts['change'])
-        except ValueError:
-            raise error.Abort('Argument of --change must be an integer')

[hub, 2018/10/01 16:06:14]

I'm not sure I understand correctly. Do you bail if the parameter to -c isn't an
int?

So what if one pass `-c .` (I do that all the time). Also changset id are sha1.
So how does this work?

[Vasily Kuznetsov, 2018/10/01 16:32:51]

Yeah, it seems that repo[x] kind of expects x to be an int (a local revision
number that hg uses). I thought that's the normal use case that everyone has
based on the error message in the ticket.

Sha1 hashes  don't work out of the box (I tried), but I can try to figure out
how to make them work.

[Vasily Kuznetsov, 2018/10/02 10:06:44]

I switched to using repo.revs() API. It's not documented here:
https://www.mercurial-scm.org/wiki/MercurialApi#Repositories but it works with
all kinds of revision ids: hashes, branches, bookmarks, tags and local
sequential numbers. It also produces nice looking error messages when the
revision is not found -- without us having to do anything.

Not sure if there's a better way but if there is, it's not in the documentation.

+        rev_no = repo.revs(opts['change']).first()
         rev = repo[rev_no]
         args.extend(['--rev', '{}:{}'.format(rev.parents()[0], rev)])
     elif opts.get('revision'):
         args.extend(['--rev', opts['revision']])
     else:
         raise error.Abort('What should be reviewed? Either --revision or --change is required.')
 
     if not opts.get('issue'):
         # New issue, make sure title and message are set
         fulltitle = None
@@ skipping 98 matching lines @@
   </body>
 </html>
 ''' % port
 
     # Run the upload tool
     issue, patchset = scope['RealMain']([upload_path] + args)
 
     # Wait for the page to check in and retrieve issue URL
     if server:
         server.handle_request()