Issue 7016 - Convert serialization functions into generators

test/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 178 matching lines @@
   addDefaults(expected);
 
   let filter = Filter.fromText(text);
   if (postInit)
     postInit(filter);
   let result = serializeFilter(filter);
   test.equal(result.sort().join("\n"), expected.sort().join("\n"), text);
 
   // Test round-trip
   let filter2;
-  let buffer = [];
-  filter.serialize(buffer);
-  if (buffer.length)
-  {
-    let map = Object.create(null);
-    for (let line of buffer.slice(1))
-    {
-      if (/(.*?)=(.*)/.test(line))
-        map[RegExp.$1] = RegExp.$2;
-    }
-    filter2 = Filter.fromObject(map);
-  }
-  else
-    filter2 = Filter.fromText(filter.text);
+  filter2 = Filter.fromText(filter.text);
 
   test.equal(serializeFilter(filter).join("\n"), serializeFilter(filter2).join("\n"), text + " deserialization");
 }
 
 exports.testFilterClassDefinitions = function(test)
 {
   test.equal(typeof Filter, "function", "typeof Filter");
   test.equal(typeof InvalidFilter, "function", "typeof InvalidFilter");
   test.equal(typeof CommentFilter, "function", "typeof CommentFilter");
   test.equal(typeof ActiveFilter, "function", "typeof ActiveFilter");
@@ skipping 388 matching lines @@
   // This compares the references to make sure that both refer to the same
   // object (#6815).
   test.equal(filter1.domains, filter2.domains);
 
   let filter3 = Filter.fromText("www.example.com##.bar");
 
   test.notEqual(filter2.domains, filter3.domains);
 
   test.done();
 };