Issue 7016 - Convert serialization functions into generators

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 468 matching lines @@
             subscription.filters.length == 0))
       {
         subscriptions.push(subscription);
       }
     }
 
     yield "# Adblock Plus preferences";
     yield "version=" + this.formatVersion;
 
     let saved = new Set();
-    let buf = [];
 
     // Save subscriptions
     for (let subscription of subscriptions)
     {
-      yield "";
+      yield* subscription.serialize();
 
-      subscription.serialize(buf);
       if (subscription.filters.length)

[Manish Jethani, 2018/10/22 20:18:01]

We don't really need this check, as I said in my previous comment. We can never
guarantee that the list will be non-empty due to the asynchronous nature of this
operation.

[Jon Sonesen, 2018/10/22 22:59:36]

My bad, I'll fix it 

       {
-        buf.push("", "[Subscription filters]");
-        subscription.serializeFilters(buf);
+        yield* subscription.serializeFilters();
       }
-      for (let line of buf)
-        yield line;
-      buf.splice(0);
     }
 
     // Save filter data
     for (let subscription of subscriptions)
     {
       for (let filter of subscription.filters)
       {
         if (!saved.has(filter.text))
         {
-          filter.serialize(buf);
+          yield* filter.serialize();
           saved.add(filter.text);
-          for (let line of buf)
-            yield line;
-          buf.splice(0);
         }
       }
     }
   }
 
   /**
    * Saves all subscriptions back to disk.
    * @returns {Promise} A promise resolved or rejected when saving is complete.
    */
   saveToDisk()
@@ skipping 147 matching lines @@
  *   disconnected from its filters.
  */
 function disconnectSubscriptionFilters(subscription)
 {
   if (!filterStorage.knownSubscriptions.has(subscription.url))
     return;
 
   for (let filter of subscription.filters)
     filter.removeSubscription(subscription);
 }