Issue 7016 - Convert serialization functions into generators

lib/filterStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 473 matching lines @@
 
     yield "# Adblock Plus preferences";
     yield "version=" + this.formatVersion;
 
     let saved = new Set();
 
     // Save subscriptions
     for (let subscription of subscriptions)
     {
       yield* subscription.serialize();
-
-      if (subscription.filters.length)

[Manish Jethani, 2018/10/22 20:18:01]

We don't really need this check, as I said in my previous comment. We can never
guarantee that the list will be non-empty due to the asynchronous nature of this
operation.

[Jon Sonesen, 2018/10/22 22:59:36]

My bad, I'll fix it 

-      {
-        yield* subscription.serializeFilters();
-      }
+      yield* subscription.serializeFilters();
     }
 
     // Save filter data
     for (let subscription of subscriptions)
     {
       for (let filter of subscription.filters)
       {
         if (!saved.has(filter.text))
         {
           yield* filter.serialize();
@@ skipping 158 matching lines @@
  *   disconnected from its filters.
  */
 function disconnectSubscriptionFilters(subscription)
 {
   if (!filterStorage.knownSubscriptions.has(subscription.url))
     return;
 
   for (let filter of subscription.filters)
     filter.removeSubscription(subscription);
 }