Issue 7016 - Convert serialization functions into generators

lib/subscriptionClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 107 matching lines @@
     if (value != this._disabled)
     {
       let oldValue = this._disabled;
       this._disabled = value;
       filterNotifier.emit("subscription.disabled", this, value, oldValue);
     }
     return this._disabled;
   },
 
   /**
-   * Serializes the subscription for writing out on the disk.

[Manish Jethani, 2018/10/23 03:02:18]

Nit: "on the disk" ... we could lose the "the" (it's not there in the
lib/filterClasses.js version).

[Jon Sonesen, 2018/10/23 03:13:55]

Done.

+   * Serializes the subscription for writing out on disk.
    * @yields {string}
    */
   *serialize()
   {
     let {url, type, _title, _fixedTitle, _disabled} = this;
 
     yield "[Subscription]";
     yield "url=" + url;
 
     if (type)
@@ skipping 145 matching lines @@
   /**
    * See Subscription.serialize()
    * @inheritdoc
    */
   *serialize()
   {
     let {defaults, _lastDownload} = this;
 
     yield* Subscription.prototype.serialize.call(this);
 
-    if (defaults && defaults.length)

[Manish Jethani, 2018/10/23 03:02:18]

Thinking about related changes now, we don't need to check `defaults.length`
here, just checking for `defaults` being truthy should be enough.

[Jon Sonesen, 2018/10/23 03:13:55]

Done.

[Manish Jethani, 2018/10/23 03:15:59]

You made the change in the wrong place :)

+    if (defaults)
     {
       yield "defaults=" +
             defaults.filter(
               type => SpecialSubscription.defaultsMap.has(type)
             ).join(" ");
     }
     if (_lastDownload)
       yield "lastDownload=" + _lastDownload;
   }
 });
@@ skipping 277 matching lines @@
     if (errors)
       yield "errors=" + errors;
     if (version)
       yield "version=" + version;
     if (requiredVersion)
       yield "requiredVersion=" + requiredVersion;
     if (downloadCount)
       yield "downloadCount=" + downloadCount;
   }
 });