Issue 7016 - Convert serialization functions into generators

test/filterClasses.js

Index: test/filterClasses.js
===================================================================
--- a/test/filterClasses.js
+++ b/test/filterClasses.js
@@ -191,30 +191,17 @@
   let filter = Filter.fromText(text);
   if (postInit)
     postInit(filter);
   let result = serializeFilter(filter);
   test.equal(result.sort().join("\n"), expected.sort().join("\n"), text);
 
   // Test round-trip
   let filter2;
-  let buffer = [];

[Manish Jethani, 2018/10/04 05:30:00]

We should just change this to:

  let buffer = [...filter.serialize()];

And leave the rest of it as it is.

[Jon Sonesen, 2018/10/06 00:06:34]

Acknowledged.

-  filter.serialize(buffer);
-  if (buffer.length)
-  {
-    let map = Object.create(null);
-    for (let line of buffer.slice(1))
-    {
-      if (/(.*?)=(.*)/.test(line))
-        map[RegExp.$1] = RegExp.$2;
-    }
-    filter2 = Filter.fromObject(map);
-  }
-  else
-    filter2 = Filter.fromText(filter.text);
+  filter2 = Filter.fromText(filter.text);
 
   test.equal(serializeFilter(filter).join("\n"), serializeFilter(filter2).join("\n"), text + " deserialization");
 }
 
 exports.testFilterClassDefinitions = function(test)
 {
   test.equal(typeof Filter, "function", "typeof Filter");
   test.equal(typeof InvalidFilter, "function", "typeof InvalidFilter");